[DEECo] [d3scomp/JDEECo] 768911: Some suggestions for the KnowledgeManagersView cla...

Mon Nov 4 12:45:01 CET 2013

  Branch: refs/heads/newgen-iliasg
  Home:   https://github.com/d3scomp/JDEECo
  Commit: 7689113fa713fa235dd176609000efc0e8f87d75
      https://github.com/d3scomp/JDEECo/commit/7689113fa713fa235dd176609000efc0e8f87d75
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagersView.java

  Log Message:
  -----------
  Some suggestions for the KnowledgeManagersView class.
@rima-alali, @keznikl, @mkit

  Commit: f1971b355ee4032dff6107ebcf869c97d553a27e
      https://github.com/d3scomp/JDEECo/commit/f1971b355ee4032dff6107ebcf869c97d553a27e
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/RuntimeModelTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/ProcessTaskTest.java

  Log Message:
  -----------
  Extensions of the SampleRuntimeModel class to create also an ensemble.

  Commit: 30f8c7bcfccfb55524e2c81e999926c990e07947
      https://github.com/d3scomp/JDEECo/commit/30f8c7bcfccfb55524e2c81e999926c990e07947
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/model/RuntimeModel.genmodel
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentInstance.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/EnsembleDefinition.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeCoordinator.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeMember.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentInstanceImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/EnsembleDefinitionImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeCoordinatorImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeMemberImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataFactoryImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataFactory.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleCoordinatorTask.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMemberTask.java
    R jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleTask.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/RuntimeModelTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/EnsembleTaskTest.java

  Log Message:
  -----------
  Changes in the meta-model:
- remove ComponentInstance.id
- change OtherKnowledgeManagersAccess to KnowledgeManagersView
- have separate scheduling specifications for the member and the
coordinator (the main reason is to have separate triggers)

Further changes include separation of the the EnsembleTask into two (one
for a coordinator, another for all members). This is because they have
different scheduling. They will share a lot of implementation via some
abstract predecessor (the class for the predecessor is not in place
yet).

  Commit: 0d9d721955551d93f671f7babdd549f6bcc87509
      https://github.com/d3scomp/JDEECo/commit/0d9d721955551d93f671f7babdd549f6bcc87509
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    R jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMemberTask.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMembersTask.java

  Log Message:
  -----------
  EnsembleMemberTask renamed EnsembleMembersTask to signify that the task
actually handles multiple instances of the member role in ensembles of
the same ensemble definition.

  Commit: aa9f302c92c764d4ade19724002d2f931bf032b6
      https://github.com/d3scomp/JDEECo/commit/aa9f302c92c764d4ade19724002d2f931bf032b6
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMemberTask.java
    R jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMembersTask.java

  Log Message:
  -----------
  Last change - renaming of the EnsembleMemberTask to plural reverted.

  Commit: 01a24097cd8133636c0bb0e3d3c2157a068daf27
      https://github.com/d3scomp/JDEECo/commit/01a24097cd8133636c0bb0e3d3c2157a068daf27
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentProcess.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentProcessImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java

  Log Message:
  -----------
  added isActive flag to the Process class in the meta-model

  Commit: ee72bc0db1e47c805a8397262b187582ed5d0446
      https://github.com/d3scomp/JDEECo/commit/ee72bc0db1e47c805a8397262b187582ed5d0446
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagersView.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/EnsembleDefinition.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/EnsembleDefinitionImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java
    R jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleCoordinatorTask.java
    R jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleMemberTask.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleTask.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/Task.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/EnsembleTaskTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/ProcessTaskTest.java

  Log Message:
  -----------
  The split of coordinator vs. member scheduling of an ensemble reverted.
It didn't really solve the problem I had in mind (i.e. that knowledge
paths of triggers have to be striped of member/coord prefix) and by
itself, it was an overkill.

There are some more architectural suggestions in the comments.
Essentially it seems that it would make a lot of sense to have separate
trigger listeners:
KnowledgeManager: triggered(Trigger)
KnowledgeManagersView: triggered(ReadOnlyKnowledgeManager, Trigger)
Task: triggered(Task)

  Commit: 40d7ffa94564fc3bd24df5993bf98c39fcae7999
      https://github.com/d3scomp/JDEECo/commit/40d7ffa94564fc3bd24df5993bf98c39fcae7999
  Author: Tomas Bures <bures at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/ExecutionListener.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/Executor.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagerException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeNotFoundException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeScheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/Scheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/ParamHolder.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/executor/ExecutorTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeSchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/SchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/EnsembleTaskTest.java

  Log Message:
  -----------
  Updated the FIXMEs that I've inserted in the code so that they identify
me as their author. Now, it should be clear who is to be consulted if
any of the FIXMEs is not clear.

  Commit: 50926d7ddc9655744993080f00c0aa10a632ac0b
      https://github.com/d3scomp/JDEECo/commit/50926d7ddc9655744993080f00c0aa10a632ac0b
  Author: mkit <kit at d3s.mff.cuni.cz>
  Date:   2013-11-03 (Sun, 03 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/model/RuntimeModel.genmodel
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/ExecutionListener.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/Executor.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagerException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagersView.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeNotFoundException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentInstance.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentProcess.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeCoordinator.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeMember.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentInstanceImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentProcessImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeCoordinatorImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeMemberImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataFactoryImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataFactory.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeScheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/Scheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleTask.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/ParamHolder.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/Task.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/executor/ExecutorTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/RuntimeModelTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeSchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/SchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/EnsembleTaskTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/ProcessTaskTest.java

  Log Message:
  -----------
  Merge pull request #80 from d3scomp/newgen-bures

Changes in the meta-model + separation of the EnsembleTask to two tasks (one for coordinator and another for members)

  Commit: b049c10645c2e72bada0245f63e36ba0ee1375ac
      https://github.com/d3scomp/JDEECo/commit/b049c10645c2e72bada0245f63e36ba0ee1375ac
  Author: Ilias Gerostathopoulos <iliasger at gmail.com>
  Date:   2013-11-04 (Mon, 04 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/model/RuntimeModel.genmodel
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/ExecutionListener.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/executor/Executor.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagerException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeManagersView.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/knowledge/KnowledgeNotFoundException.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentInstance.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentProcess.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeCoordinator.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeMember.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentInstanceImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentProcessImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeCoordinatorImpl.java
    A jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeMemberImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataFactoryImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataFactory.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeScheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/scheduler/Scheduler.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/EnsembleTask.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/ParamHolder.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/task/Task.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/executor/ExecutorTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/RuntimeModelTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/model/runtime/SampleRuntimeModel.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/LocalTimeSchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/scheduler/SchedulerTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/EnsembleTaskTest.java
    M jdeeco-core/test/cz/cuni/mff/d3s/deeco/task/ProcessTaskTest.java

  Log Message:
  -----------
  Merge branch 'newgen' into newgen-iliasg

  Commit: 40c8aa13ef0c1ef8ebf4a48fa16ad7e89b66d3cc
      https://github.com/d3scomp/JDEECo/commit/40c8aa13ef0c1ef8ebf4a48fa16ad7e89b66d3cc
  Author: Ilias Gerostathopoulos <iliasger at gmail.com>
  Date:   2013-11-04 (Mon, 04 Nov 2013)

  Changed paths:
    M jdeeco-core/model/RuntimeModel.ecore
    M jdeeco-core/model/RuntimeModel.ecorediag
    M jdeeco-core/model/RuntimeModel.genmodel
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/ComponentInstance.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/Parameter.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeCoordinator.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/api/PathNodeMember.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ComponentInstanceImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/ParameterImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeCoordinatorImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/PathNodeMemberImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataFactoryImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/impl/RuntimeMetadataPackageImpl.java
    M jdeeco-core/src/cz/cuni/mff/d3s/deeco/model/runtime/meta/RuntimeMetadataPackage.java

  Log Message:
  -----------
  Updates in Ecore model

1. Changed Parameter -> KnowledgePath from reference to containment
(there was a missing ownership that didn't let the serialization
complete)
2. Set Parameter.direction: 'unsettable="true"' (in order to correctly
serialize all ParameterDirection:EEnum values)

Compare: https://github.com/d3scomp/JDEECo/compare/3aa865471bd6...40c8aa13ef0c